Merged
Conversation
Preview of modified filesPreview of modified Markdown: |
mnocon
force-pushed
the
search-perform-count
branch
from
820fd0e to
e08b557
Compare
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
approved these changes
May 6, 2026
ibexa-workflow-automation-1
Bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
code_samples/ change report
|
bnowak
approved these changes
May 6, 2026
adriendupuis
requested changes
May 7, 2026
Contributor
There was a problem hiding this comment.
The example is a bit long. We could hightlight the two lines ->performCount = false;
But it's strange to execute an empty request, the example is a bit long for what it documents. I would focus more on the query setting and forget the surrounding. Previous and following full examples are there for that.
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
|
adriendupuis
approved these changes
May 7, 2026
mnocon
added a commit
that referenced
this pull request
May 7, 2026
* Described disabling counting the results * Fixed link * Update docs/search/search_api.md Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> --------- Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target: 5.0, 4.6
Based on feedback provided on community Slack